Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move #endif to fix PwmOut.h doxygen #8572

Merged
merged 1 commit into from
Oct 30, 2018
Merged

Conversation

c1728p9
Copy link
Contributor

@c1728p9 c1728p9 commented Oct 29, 2018

Description

Move the #endif up so it does not include the closing bracket of PwmOut. This allows the doxygen for PwmOut, classmbed_1_1_pwm_out.html, to build.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Move the #endif up so it does not include the closing bracket of
PwmOut. This allows the doxygen for PwmOut, classmbed_1_1_pwm_out.html,
to build.
@c1728p9
Copy link
Contributor Author

c1728p9 commented Oct 29, 2018

This problem was introduced in #8412

@cmonr
Copy link
Contributor

cmonr commented Oct 29, 2018

@c1728p9 What was the command that allowed you to build the file?

Looking into doxygen issues atm, and wondering if this is related to #8574

@c1728p9
Copy link
Contributor Author

c1728p9 commented Oct 29, 2018

Hi @cmonr I used the command

> doxygen doxyfile_options

@cmonr
Copy link
Contributor

cmonr commented Oct 29, 2018

@c1728p9 doxygen --version ?

@c1728p9
Copy link
Contributor Author

c1728p9 commented Oct 29, 2018

I'm using doxygen version 1.8.10

@cmonr
Copy link
Contributor

cmonr commented Oct 29, 2018

@c1728p9 Thanks for the datapoint!

@cmonr
Copy link
Contributor

cmonr commented Oct 29, 2018

Now that I'm taking another look at this, I'm really bothered that CI didn't catch it...

@0xc0170 0xc0170 merged commit 3b970c1 into ARMmbed:master Oct 30, 2018
@0xc0170 0xc0170 removed the needs: CI label Oct 30, 2018
@cmonr cmonr removed the rollup PR label Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants